Add functions for getting a files stats#248
Open
gnuoy wants to merge 1 commit intoopenstack-charmers:masterfrom
Open
Add functions for getting a files stats#248gnuoy wants to merge 1 commit intoopenstack-charmers:masterfrom
gnuoy wants to merge 1 commit intoopenstack-charmers:masterfrom
Conversation
ajkavanagh
requested changes
Nov 16, 2020
Collaborator
ajkavanagh
left a comment
ajkavanagh
left a comment
There was a problem hiding this comment.
Looks good, but I think it needs a change due to how Stdout/stdout handling changed in the last year.
| unit = get_unit_from_name(unit_name, model=model) | ||
| output = await unit.run( | ||
| 'stat --format "{}" {}'.format(stat_format, remote_file)) | ||
| return output.data.get('results')['Stdout'].strip() |
Collaborator
There was a problem hiding this comment.
If this PR is still needed, then I think this needs to go through _normalise_action_results?
ajkavanagh
added
the
stale
coreycb
pushed a commit
to coreycb/zaza
that referenced
this pull request
Oct 17, 2023
…tions Fix glance simplestreams sync test races
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.