.github/workflows/tox.yaml

-Original file line number
+Diff line change
@@ Expand Up / @@ -9,7 +9,10 @@ jobs: @@
         runs-on: ubuntu-latest
         strategy:
           matrix:
-            python-version: ['3.8', '3.10', '3.11', '3.12']
+            python-version:
+              - '3.8'  # focal
+              - '3.10' # jammy
+              - '3.12' # noble
         steps:
         - uses: actions/checkout@v1
         - name: Set up Python ${{ matrix.python-version }}
@@ Expand Down @@

setup.py

-Original file line number
+Diff line change
@@ Expand Up / @@ -25,16 +25,13 @@ @@
     version = "0.0.1.dev1"
     install_require = [
+        'importlib-metadata<8.0.0',  # compatible with py38
+        'setuptools_scm<8.2.0',  # https://github.com/canonical/charmcraft/pull/2275
         'aiohttp<4.0.0',  # aiohttp/_http_parser.c:16227:5: error: lvalue required as increment operand
         'oslo.config<6.12.0',  # pin at stable/train to retain Py3.5 support
         'async_generator',
-        # Newer versions require a Rust compiler to build, see
-        # * https://github.com/openstack-charmers/zaza/issues/421
-        # * https://mail.python.org/pipermail/cryptography-dev/2021-January/001003.html
-        'cryptography<3.4',
-        'hvac<0.7.0',
+        'cryptography',
+        'hvac',
         'jinja2',
         'juju-wait',
         'PyYAML',
@@ Expand Down @@

test-requirements.txt

-Original file line number
+Diff line change
@@ -1,8 +1,8 @@
     aiounittest
+    pydocstyle<4.0.0
     flake8>=5  # Python 3.8 compatibility in pyflakes 2.1.0+
     flake8-docstrings
     flake8-per-file-ignores
-    pydocstyle<4.0.0
     coverage
     mock>=1.2
     pytest
@@ Expand Down @@

tox.ini

-Original file line number
+Diff line change
@@ Expand Up / @@ -21,6 +21,7 @@ passenv = @@
     deps =
         -c{env:PIP_CONSTRAINTS:{toxinidir}/constraints-juju29.txt}
         -r{toxinidir}/test-requirements.txt
+    install_command = python -I -m pip install --no-binary ":all:" {opts} {packages}
     commands = pytest --cov=./zaza/ {posargs} {toxinidir}/unit_tests
     [testenv:.pkg]
@@ Expand Down @@

Unpinning Cryptography #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

freyes wants to merge 7 commits into openstack-charmers:master from freyes:cryptography-pinning

-Original file line number
+Diff line change
@@ Expand Up / @@ -9,7 +9,10 @@ jobs: @@
         runs-on: ubuntu-latest
         strategy:
           matrix:
-            python-version: ['3.8', '3.10', '3.11', '3.12']
+            python-version:
+              - '3.8'  # focal
+              - '3.10' # jammy
+              - '3.12' # noble
         steps:
         - uses: actions/checkout@v1
         - name: Set up Python ${{ matrix.python-version }}
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -25,16 +25,13 @@ @@
     version = "0.0.1.dev1"
     install_require = [
+        'importlib-metadata<8.0.0',  # compatible with py38
+        'setuptools_scm<8.2.0',  # https://github.com/canonical/charmcraft/pull/2275
         'aiohttp<4.0.0',  # aiohttp/_http_parser.c:16227:5: error: lvalue required as increment operand
         'oslo.config<6.12.0',  # pin at stable/train to retain Py3.5 support
         'async_generator',
-        # Newer versions require a Rust compiler to build, see
-        # * https://github.com/openstack-charmers/zaza/issues/421
-        # * https://mail.python.org/pipermail/cryptography-dev/2021-January/001003.html
-        'cryptography<3.4',
-        'hvac<0.7.0',
+        'cryptography',
+        'hvac',
         'jinja2',
         'juju-wait',
         'PyYAML',
@@ Expand Down @@

-Original file line number
+Diff line change
@@ -1,8 +1,8 @@
     aiounittest
+    pydocstyle<4.0.0
     flake8>=5  # Python 3.8 compatibility in pyflakes 2.1.0+
     flake8-docstrings
     flake8-per-file-ignores
-    pydocstyle<4.0.0
     coverage
     mock>=1.2
     pytest
@@ Expand Down @@

-Original file line number
+Diff line change
@@ Expand Up / @@ -21,6 +21,7 @@ passenv = @@
     deps =
         -c{env:PIP_CONSTRAINTS:{toxinidir}/constraints-juju29.txt}
         -r{toxinidir}/test-requirements.txt
+    install_command = python -I -m pip install --no-binary ":all:" {opts} {packages}
     commands = pytest --cov=./zaza/ {posargs} {toxinidir}/unit_tests
     [testenv:.pkg]
@@ Expand Down @@

Provide feedback