Draft
Conversation
The commit 29944df pinned hvac to `<0.7.0`, because it was breaking the tests, this is no longer necessary.
Pass `--no-binary ":all:"` to the tox install_command, so all dependencies get built from sources, this allows to detect possible issues when using zaza in non-x86 environments where there is no published binary wheel in pypi.
This is the last version compatible with Python 3.8 https://pypi.org/project/importlib-metadata/7.2.1/
|
Hi @freyes, thanks for working on this, and we would like to see this eventually unpinned. For the issue seen in the CI, we've seen that before for python 3.8, and it worked well if "setuptool_scm<8.2.0" is in the constraints (instead of a requirement) see canonical/charm-logrotated#72 for example. Hope that helps |
Pinning pydocstyle before flake8 allows us to control the version, otherwise flake8 pulls in a newer version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #421