fix: Cross domain configuration

[lu-yg]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Improved cross-origin request handling now supports flexible origins, methods, and headers for seamless cross-domain interactions.

• Chores

  • Streamlined configuration settings and removed unused dependencies to enhance maintainability and simplify system operations.

[coderabbitai]

Walkthrough

This pull request restructures the CORS configuration and cleans up unused imports across several Java files. The CORS configuration in WebConfig.java has been shifted from a registry-based approach to a filter-based one via a new corsFilter() bean, while the application-dev.yml file now allows all origins using a wildcard. Additionally, several unused import statements in controller, service, and test files have been removed, and minor formatting adjustments (blank lines) have been introduced in select service implementation files.

Changes

File(s)	Change Summary
app/src/main/java/.../WebConfig.java app/src/main/resources/.../application-dev.yml	Updated CORS configuration: replaced registry-based setup with a filter-based approach and changed allowed origins from a specific IP to wildcard (*), simplifying the configuration.
base/src/main/java/.../BlockGroupController.java base/src/main/java/.../AiChatClient.java base/src/main/java/.../AiChatServiceImpl.java base/src/test/java/.../AiChatControllerTest.java base/src/test/java/.../BlockGroupControllerTest.java base/src/test/java/.../AiChatServiceImplTest.java	Removed unused import statements to clean up dependencies and simplify the code base.
base/src/main/java/.../BlockGroupServiceImpl.java base/src/main/java/.../BlockServiceImpl.java	Added blank lines for formatting purposes; no functional change.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant CorsFilter
    participant Application
    Client->>CorsFilter: Send HTTP Request
    CorsFilter-->>Client: Validate request (origin, headers, methods)
    CorsFilter->>Application: Forward validated request
    Application-->>CorsFilter: Process response
    CorsFilter-->>Client: Return response with appropriate CORS headers

Loading

Possibly related PRs

• fix(app): 修复启动时h2脚本与local配置问题 #176: Updated CORS configuration in application-local.yml aligning with similar CORS updates.

Poem

In a field of code I happily roam,
Rewriting CORS to give our API a new home.
Imports that were old now hop away,
Blank lines dance in a refreshing display.
With each line of change, my heart does leap—
A rabbit’s delight as our code runs deep!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

app/src/main/resources/application-dev.yml (1)

63-63: Consider restricting allowed origins for non-development environments.

By setting allowed-origins to *, you're permitting requests from any domain. This simplifies development and testing but may pose a security risk in production. You might configure environment-specific restrictions or refine your allowed origins list to ensure only trusted domains can access your application.

app/src/main/java/com/tinyengine/it/config/filter/WebConfig.java (1)

31-50: Validate that filter-based configuration meets your CORS requirements.

1. The code properly sets up a CorsConfiguration object and registers it with UrlBasedCorsConfigurationSource.
2. setAllowedOriginPatterns(crosDomainList) uses values from allowedOrigins, which is currently set to "*". For production-grade code, consider restricting or parameterizing domain lists via environment-specific configurations.
3. Allowing any method and header while setting allowCredentials to true is flexible but significantly broadens cross-origin permissions. Double-check the security implications.

Would you like me to generate additional environment-based configuration examples or strategies for restricting origins only to known domains?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a95eae3 and 8a4041c.

📒 Files selected for processing (10)

• app/src/main/java/com/tinyengine/it/config/filter/WebConfig.java (1 hunks)
• app/src/main/resources/application-dev.yml (1 hunks)
• base/src/main/java/com/tinyengine/it/controller/BlockGroupController.java (0 hunks)
• base/src/main/java/com/tinyengine/it/gateway/ai/AiChatClient.java (0 hunks)
• base/src/main/java/com/tinyengine/it/service/app/impl/AiChatServiceImpl.java (0 hunks)
• base/src/main/java/com/tinyengine/it/service/material/impl/BlockGroupServiceImpl.java (1 hunks)
• base/src/main/java/com/tinyengine/it/service/material/impl/BlockServiceImpl.java (1 hunks)
• base/src/test/java/com/tinyengine/it/controller/AiChatControllerTest.java (0 hunks)
• base/src/test/java/com/tinyengine/it/controller/BlockGroupControllerTest.java (0 hunks)
• base/src/test/java/com/tinyengine/it/service/app/impl/AiChatServiceImplTest.java (0 hunks)

💤 Files with no reviewable changes (6)

• base/src/test/java/com/tinyengine/it/controller/BlockGroupControllerTest.java
• base/src/test/java/com/tinyengine/it/service/app/impl/AiChatServiceImplTest.java
• base/src/main/java/com/tinyengine/it/gateway/ai/AiChatClient.java
• base/src/test/java/com/tinyengine/it/controller/AiChatControllerTest.java
• base/src/main/java/com/tinyengine/it/controller/BlockGroupController.java
• base/src/main/java/com/tinyengine/it/service/app/impl/AiChatServiceImpl.java

✅ Files skipped from review due to trivial changes (2)

• base/src/main/java/com/tinyengine/it/service/material/impl/BlockServiceImpl.java
• base/src/main/java/com/tinyengine/it/service/material/impl/BlockGroupServiceImpl.java

🔇 Additional comments (1)

app/src/main/java/com/tinyengine/it/config/filter/WebConfig.java (1)

16-25: Imports are consistent with the new filter-based CORS approach.

The newly introduced imports are correct and align with the transition to the CorsFilter-based setup. No issues found here.