This repository was archived by the owner on May 23, 2023. It is now read-only.
docs(Tracer): remove link to nonexistent method#381
Open
dmedinag wants to merge 1 commit intoopentracing:masterfrom
Open
docs(Tracer): remove link to nonexistent method#381dmedinag wants to merge 1 commit intoopentracing:masterfrom
dmedinag wants to merge 1 commit intoopentracing:masterfrom
Conversation
The previously referred method was removed from the API, hence it no longer exists. Must say too that semantic versioning was used wrong! Removing this method was a breaking change. The same as removing `ScopeManager.activate(Span span, boolean finishSpanOnClose)`. Please be more careful with the versioning of the libs, deprecating a method is better than removing directly :)
|
Nope, it wasn't used incorrectly. OpenTracing never made it out of 0.y.z:
|
venuprasadnaik
approved these changes
Jun 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previously referred method was removed from the API, hence it no longer exists. Must say too that semantic versioning was used wrong! Removing this method was a breaking change. The same as removing
ScopeManager.activate(Span span, boolean finishSpanOnClose). Please be more careful with the versioning of the libs, deprecating a method is better than removing directly :)