Conversation
machisuji
requested changes
Oct 17, 2025
Member
There was a problem hiding this comment.
👍 Looks good in principle. However, as long as this feature is experimental, it's not sensible to always start hocuspocus only for it to do nothing.
I suggest to remove the definition from the docker-compose.yaml and add a hocuspocus.yaml containing its definition.
If people do want to use it then they can simply add that definition like
docker compose up -f docker-compose.yaml -f hocuspocus.yaml
It would be good to add a mention of this to the README as well explaining how to turn on (and use) this experimental feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.