Parameterize postgres db and user#143
Draft
WaleedMortaja wants to merge 2 commits intoopf:stable/17from
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://github.com/opf/openproject-docker-compose
What are you trying to accomplish?
Continue the work made in #142: Creating more parameters in environment variables.
What approach did you choose and why?
The same approach, but I am not sure if you would prefer to allow this flexibility or not, so I made it as a separate PR.
IMPORTANT NOTE: There are documentations that will need to be changed if this gets merged, because the values for db or username are hard-coded there. An example that I faced, but not necessary the only one, is migration-to-postgresql17
I would suggest editing the commands to be like:
Or assume the variables are always set?
Side note: The quotation for
DATABASE_URLmakessourceexecute without misinterpretation (Otherwise,&in the URL creates a background job)Merge checklist