New Praise Data Format#175
Merged
gregv merged 4 commits intoopportunity-hack:developfrom Oct 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the save_praise function by adding ohack.dev user ID mappings for both praise senders and receivers. The changes fetch corresponding ohack.dev user IDs from Slack user IDs and store them in the praise data for better user tracking and linking.
- Adds logic to retrieve and store ohack.dev user IDs for both praise sender and receiver
- Changes logging from debug to info level for the final save operation
- Removes the initial debug log statement
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
gregv
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies the data format of praise data sent from praise bot's submitted praise form with the new format:
`
{
praise_channel: (string)
praise_gif: (string)
praise_message: (string)
praise_receiver: (string)
praise_receiver_ohack_id: (string)
praise_sender: (string)
praise_sender_ohack_id: (string)
timestamp: (string)
}
wherepraise_receiver_ohack_idis the OHack user id of the praise receiver's public profile andpraise_sender_ohack_id` is the OHack user id of the praise sender's public profile