Add PropertyFileHandler to ValueChecker. #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This PR is ready for code review. The failed test group is due to a recent update of annotated jdk at typetools. |
wmdietl
requested changes
Apr 25, 2020
Member
wmdietl
left a comment
wmdietl
left a comment
There was a problem hiding this comment.
Thanks for working on this!
Can you also add documentation of this new feature to the manual?
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/value/PropertyFileHandler.java
Show resolved
Hide resolved
xingweitian
commented
May 27, 2020
framework/src/main/java/org/checkerframework/common/value/PropertyFileHandler.java
Outdated
Show resolved
Hide resolved
xingweitian
commented
May 27, 2020
framework/src/main/java/org/checkerframework/common/value/PropertyFileHandler.java
Outdated
Show resolved
Hide resolved
xingweitian
commented
May 27, 2020
framework/src/main/java/org/checkerframework/common/value/PropertyFileHandler.java
Show resolved
Hide resolved
xingweitian
commented
May 27, 2020
framework/src/main/java/org/checkerframework/common/value/PropertyFileHandler.java
Show resolved
Hide resolved
xingweitian
commented
May 27, 2020
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
xingweitian
commented
May 27, 2020
framework/src/main/java/org/checkerframework/common/value/ValueQualifierHierarchy.java
Outdated
Show resolved
Hide resolved
xingweitian
commented
May 27, 2020
framework/src/main/java/org/checkerframework/common/value/ValueQualifierHierarchy.java
Outdated
Show resolved
Hide resolved
xingweitian
commented
May 27, 2020
framework/src/main/java/org/checkerframework/common/value/ValueTreeAnnotator.java
Outdated
Show resolved
Hide resolved
wmdietl
requested changes
May 27, 2020
framework/src/main/java/org/checkerframework/common/value/PropertyFileHandler.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/value/PropertyFileHandler.java
Outdated
Show resolved
Hide resolved
| } catch (Exception e) { | ||
| checker.message( | ||
| Kind.WARNING, "Exception in PropertyFileHandler.readPropertyFromFile: " + e); | ||
| e.printStackTrace(); |
Author
There was a problem hiding this comment.
Same reason here. We cannot use reportWarning because there is no AST node to be passed to reportWarning. Same issue in the propkey checker: https://github.com/typetools/checker-framework/blob/master/checker/src/main/java/org/checkerframework/checker/propkey/PropertyKeyAnnotatedTypeFactory.java#L189
| res = prop.getProperty(key, defaultValue); | ||
| } | ||
| } catch (Exception e) { | ||
| checker.message( |
Author
There was a problem hiding this comment.
Maybe we cannot use reportWarning. There is no such an AST node to be passed to reportWarning.
| } | ||
|
|
||
| /** | ||
| * Get the first value of the {@literal @}StringVal() annotation. |
Member
There was a problem hiding this comment.
Why only first? Error if more than one?
Author
There was a problem hiding this comment.
I decide to return null if there are more than one.
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/value/ValueAnnotatedTypeFactory.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/value/ValueChecker.java
Outdated
Show resolved
Hide resolved
framework/src/main/java/org/checkerframework/common/value/ValueQualifierHierarchy.java
Outdated
Show resolved
Hide resolved
Author
|
@wmdietl This pull request is ready for another round of code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.