Skip to content

Conversation

@xesrevinu
Copy link
Member

Signed-off-by: xesrevinu <github-action@actions-template-sync.noreply.github.com>
@xesrevinu xesrevinu merged commit 6643b5c into main Nov 28, 2025
3 of 4 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

static FromTags = (layerRecord: Record<PaymentProviderTag, Layer.Layer<PaymentImpl>>) =>
Payment.Default.pipe(Layer.provide(PaymentTags.FromRecords(layerRecord)))

static client = Payment.pipe(Effect.flatMap((_) => _.use('any' as PaymentProviderTag)))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Payment client hardcodes nonexistent provider

Payment.client now calls _.use('any' as PaymentProviderTag), but PaymentProviderTag only permits paddle or stripe. When Payment.client is used (e.g., the purchase webhook sync code resolves Payment.client), the provider lookup tags.providers['any'] is undefined and Effect.provide fails before any client is returned, so the helper cannot be used at runtime.

Useful? React with 👍 / 👎.

@xesrevinu xesrevinu deleted the chore/template_sync_c01bb03 branch November 28, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants