upstream merge template repository #5
Conversation
Signed-off-by: xesrevinu <github-action@actions-template-sync.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "typecheck": { | ||
| "executor": "nx:run-commands", | ||
| "dependsOn": ["^build"], | ||
| "options": { |
There was a problem hiding this comment.
Adding dependsOn: ["^build"] makes nx typecheck pkgs-event-log invoke the build target on every dependency before running the checker. pkgs-event-log imports packages like @xstack/fx/worker/runner, and packages/fx/project.json (and most other workspace libs) define no build target, so the command now errors with “Target build not found for project pkgs-fx” rather than running type checks. Unless every dependency gains a build target, this dependency chain breaks the typecheck target.
Useful? React with 👍 / 👎.
| "expo": "^54.0.25", | ||
| "expo-asset": "^12.0.10", | ||
| "expo-audio": "^1.0.15", | ||
| "expo-bip39": "workspace:*", | ||
| "@xstack/expo-bip39": "workspace:*", | ||
| "expo-clipboard": "^8.0.7", |
There was a problem hiding this comment.
The dependency was renamed to @xstack/expo-bip39, but pnpm-lock.yaml still pins the old unscoped expo-bip39 entry (e.g., lines 369–371). With pnpm install --frozen-lockfile the installer now fails because the new specifier has no matching lock entry, blocking installs until the lockfile is regenerated for the scoped name.
Useful? React with 👍 / 👎.
Merge https://github.com/opraying/template 3c45c74