Conversation
| from . import __project__, __version__ | ||
|
|
||
| """MCP tools available in this server: | ||
| - get_compartment_by_name_tool |
There was a problem hiding this comment.
This tool should exist within the identity MCP server
There was a problem hiding this comment.
Thanks for the review comment — I agree that, compartment lookup is an identity concern and the tool already exists in the identity MCP server.
But, our intent here is to keep the Recovery Service MCP server self-sufficient from a user’s perspective. If this tool is removed, users would be required to configure multiple MCP servers (identity + recovery) just to perform basic recovery workflows, which increases setup friction and adoption complexity.
Please let me know your view on this.
| - get_database | ||
| - list_backups | ||
| - get_backup | ||
| - summarise_protected_database_backup_destination |
There was a problem hiding this comment.
| - summarise_protected_database_backup_destination | |
| - summarize_protected_database_backup_destination |
|
|
||
| ## Tools | ||
|
|
||
| - list_protected_databases(compartment_id, lifecycle_state=None, display_name=None, id=None, protection_policy_id=None, recovery_service_subnet_id=None, limit=None, page=None, sort_order=None, sort_by=None, opc_request_id=None, region=None) -> list[ProtectedDatabaseSummary] |
There was a problem hiding this comment.
There are a lot more tools in the server file than what is included here. Can we update this list?
There was a problem hiding this comment.
Thank you. Updated the list.
|
@cboffa13 Can you review the changes merged in response to the comments? |
|
Can someone please review and help merge this code ? |
Introduce a new MCP server: OCI Autonomous Recovery Service MCP Server (oci-recovery-mcp-server). This server exposes tools to query and summarize Oracle Cloud Infrastructure (OCI) Autonomous Recovery Service resources such as Protected Databases, Protection Policies, Recovery Service Subnets, DB Homes/Databases, DB Systems, and related metrics. It also includes a comprehensive test suite for the new tools and models, along with linting fixes.
Key changes:
New package at src/oci-recovery-mcp-server with:
New unit tests:
Lint fixes and minor improvements, plus a few additional custom tools
Implemented tools (server API surface):
Identity/compartment helper:
Recovery Service - Protected Databases and health:
Recovery policies and subnets:
Recovery metrics:
Database/backup surface for context:
Motivation:
Dependencies:
Fixes # N/A (feature addition)
Type of change
How Has This Been Tested?
Added unit tests for tool behavior and models:
Tests validate request building, mock-backed responses, health/redo/backup summaries, and error handling paths.
Reproduce locally:
Option A (pip):
Option B (uv):
Notes:
Tests mock OCI client interactions and do not require live OCI credentials.
Test A: Tool and model unit tests (mocked)
Test B: Summary computations (health, redo, backup space)
Test Configuration:
Checklist: