Skip to content

Adding tool to fetch the public IP for databases, plus some small fixes in descriptions #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shyam2511 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adding tool to fetch the public IP for databases, plus some small fixes in descriptions #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/oci-database-mcp-server/oracle/oci_database_mcp_server/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,16 @@ class PluggableDatabase(OCIBaseModel):
None,
description="**[Required]** Gets the compartment_id of this PluggableDatabase. The `OCID`__ of the compartment. __ https://docs.cloud.oracle.com/Content/General/Concepts/identifiers.htm",
)
connection_strings: Optional[str] = Field(None, description="")
Copy link
Member

@cboffa13 cboffa13 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a description here? Also I think this should have a type associated with it instead of Any

connection_strings: Optional[Any] = Field(None, description="")
container_database_id: Optional[str] = Field(
Copy link
Member

@cboffa13 cboffa13 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

container_database_id field is marked as optional but the description it says its required. I think we need to adjust one of these

None,
description="**[Required]** Gets the container_database_id of this PluggableDatabase. The `OCID`__ of the CDB. __ https://docs.cloud.oracle.com/Content/General/Concepts/identifiers.htm",
)
defined_tags: Optional[str] = Field(
defined_tags: Optional[dict] = Field(
None,
description="Defined tags for this resource. Each key is predefined and scoped to a namespace. For more information, see `Resource Tags`__. __ https://docs.cloud.oracle.com/Content/General/Concepts/resourcetags.htm",
)
freeform_tags: Optional[str] = Field(
freeform_tags: Optional[dict] = Field(
None,
description='Free-form tags for this resource. Each tag is a simple key-value pair with no predefined name, type, or namespace. For more information, see `Resource Tags`__. Example: `{"Department": "Finance"}` __ https://docs.cloud.oracle.com/Content/General/Concepts/resourcetags.htm',
Copy link
Member

@cboffa13 cboffa13 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any examples should be in the examples argument. See https://docs.pydantic.dev/2.0/api/fields/#pydantic.fields.Field

Copy link
Member Author

@shyam2511 shyam2511 Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This model is a pojo that is never visible to the agent, hence the description shouldn't matter here

)
Expand Down
Loading