fix(agent): warn instead of error the policy removal error when polic…#2986
Open
lpegoraro wants to merge 5 commits intoorb-community:developfrom
Open
fix(agent): warn instead of error the policy removal error when polic…#2986lpegoraro wants to merge 5 commits intoorb-community:developfrom
lpegoraro wants to merge 5 commits intoorb-community:developfrom
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #2986 +/- ##
===========================================
- Coverage 48.60% 3.18% -45.42%
===========================================
Files 85 15 -70
Lines 6372 1068 -5304
===========================================
- Hits 3097 34 -3063
+ Misses 3275 1034 -2241 ☔ View full report in Codecov by Sentry. |
mfiedorowicz
reviewed
Feb 1, 2024
mfiedorowicz
reviewed
Feb 2, 2024
mfiedorowicz
reviewed
Feb 9, 2024
| if err != nil { | ||
| if err := p.request(fmt.Sprintf("policies/%s", name), &resp, http.MethodDelete, http.NoBody, "application/json", RemovePolicyTimeout); err != nil { | ||
| if strings.Contains(err.Error(), "404") { | ||
| p.logger.Warn("ignoring error from removing a policy not found", zap.String("policy_id", data.ID), zap.String("policy_name", name)) |
Member
There was a problem hiding this comment.
Can we change warning message to policy not found?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…y was not found.