Skip to content

feat: docker setup for the project#148

Open
tobiasz-gleba wants to merge 1 commit intooriginalankur:mainfrom
tobiasz-gleba:main
Open

feat: docker setup for the project#148
tobiasz-gleba wants to merge 1 commit intooriginalankur:mainfrom
tobiasz-gleba:main

Conversation

@tobiasz-gleba
Copy link

Hi, It will be nice to add the ability to use the project fom the container pkg. Here is PR, feel free to comment and adjust


**Windows users**:
- PowerShell: Use `$PWD` instead of `$(pwd)`
- CMD: Use `%cd%` instead of `$(pwd)`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PWD is not needed, the parameters can look like -v posters:/app/posters

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will create a volume named posters instead of using the host directory.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion to name the file Containerfile to keep compatibility with OCI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants