refactor code to utilize c++14 features #4783
Open
+121
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vicentebolea
commented
Jan 8, 2026
vicentebolea
commented
- Use std::make_unique whenever it can
- Use the auto keyword whenever possible (specially lambda params)
- Use of [[deprecated]]
vicentebolea
force-pushed
the
migrate-c++14-ways
branch
from
51d5e0d to
b49d98d
Compare
Collaborator
Author
|
low hanging fruits for claude-code :) |
vicentebolea
force-pushed
the
migrate-c++14-ways
branch
4 times, most recently
from
8497d59 to
b513c29
Compare
eisenhauer
reviewed
Jan 8, 2026
Member
eisenhauer
left a comment
eisenhauer
left a comment
There was a problem hiding this comment.
Just some comments for discussion...
- Use std::make_unique whenever it can - Use the auto keyword whenever possible (specially lambda params)
vicentebolea
force-pushed
the
migrate-c++14-ways
branch
from
b513c29 to
7e43618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.