Merged
Conversation
Grouloo
reviewed
Feb 8, 2025
Collaborator
Grouloo
left a comment
Grouloo
left a comment
There was a problem hiding this comment.
On est bon dans l'ensemble, il y a une coquille dans le code (voir le commentaire laissé dans src/namespaces/Seed.ts:70)
Si ça te convient, je peux faire un dernier commit réglant le problème et ajoutant des filtres pour les variété de semences, puis merge la branche.
Contributor
Author
|
@Grouloo Je viens de pousser le dernier commit, je te laisse regarder. |
ionosphere
changed the title
Collaborator
Super, je merge ça. Deux petites questions :
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.