buildgcc: Build GMP --with-pic if GCC defaults to -pie#1
Open
iseeareddoor wants to merge 1 commit intoosresearch:masterfrom
Open
buildgcc: Build GMP --with-pic if GCC defaults to -pie#1iseeareddoor wants to merge 1 commit intoosresearch:masterfrom
--with-pic if GCC defaults to -pie#1iseeareddoor wants to merge 1 commit intoosresearch:masterfrom
Conversation
GCC 6 can optionally default to building all binaries as position
independent executables (PIE). This breaks linking against static
libraries that are compiled without position independent code (PIC).
Building GMP `--with-pic` in this case seems to be the least fragile
solution.
TEST=Run `make all` and `make BUILDGCC_OPTIONS=-b build-i386` in
util/crossgcc on Debian Stretch.
Change-Id: I5f3185af9c8d599379a628e18724b217b88be974
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/17936
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Author
|
since there are no issues allowed here, I opened a pull request instead - if you rather want such things to be reported against the main heads repository, please tell. please cherry-pick this commit from upstream (coreboot@8bbd596), without it building with GCC-6 (Debian Stretch/Sid) is broken because of the default PIE compile flags. I verified that with it included the crossgcc build works and I get a qemu.rom built which outputs some coreboot stuff on the console when started with Qemu - there is little documentation on what is supposed to work with Qemu and how to test it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 6 can optionally default to building all binaries as position
independent executables (PIE). This breaks linking against static
libraries that are compiled without position independent code (PIC).
Building GMP
--with-picin this case seems to be the least fragilesolution.
TEST=Run
make allandmake BUILDGCC_OPTIONS=-b build-i386inutil/crossgcc on Debian Stretch.
Change-Id: I5f3185af9c8d599379a628e18724b217b88be974
Signed-off-by: Nico Huber nico.huber@secunet.com
Reviewed-on: https://review.coreboot.org/17936
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net
Reviewed-by: Jonathan Neuschäfer j.neuschaefer@gmx.net