🌱 Set OSV User-Agent for scorecard cli and cron workers. #4883
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kash2104 <kparikh1104@gmail.com>
kash2104
requested review from
AdamKorcz and
jeffmendoza
and removed request for
a team
dosubot
bot
added
the
size:S
Comment on lines
27
to
+28
|
|
||
| "github.com/google/osv-scanner/pkg/osv" |
Member
There was a problem hiding this comment.
this should be "github.com/google/osv-scanner/v2/pkg/osv"
Comment on lines
+44
to
45
| github.com/google/osv-scanner v1.9.2 | ||
| github.com/google/osv-scanner/v2 v2.2.4 |
Member
There was a problem hiding this comment.
when you fix this import this accidental import of v1 should go away
| "fmt" | ||
| "log" | ||
|
|
||
| "github.com/google/osv-scanner/pkg/osv" |
Member
There was a problem hiding this comment.
same comment about v2 import
|
|
||
| func main() { | ||
| info := version.GetVersionInfo() | ||
| osv.RequestUserAgent = fmt.Sprintf("scorecard-cron/%s", info.GitVersion) |
Member
There was a problem hiding this comment.
you have scorecard-cron/ here too, which is a copy/paste error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR introduces improvement to OSV API request by configuring versioned User-Agent for Scorecard.
What is the current behavior?
Currently API requests to
osv.devare made without specifying a unique user-agent.What is the new behavior (if this is a feature change)?**
Now a distinct, versioned user agent is set for the OSV API request:
scorecard/{version}for CLIscorecard-cron/{version}for cron workersTests for the changes have been added (for bug fixes/features)
Which issue(s) this PR fixes
Fixes #4029
Special notes for your reviewer
osv-scanner/1.9.2has been installed.Does this PR introduce a user-facing change?
No
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)