Conversation
- Includes the EventIdGenerator interface and implementations in the new package com.osso.event.id. - Javadoc exists for all classes. - Contains the addition of Guava 15. It may make sense to shade this in a follow up commit.
- These docs were lost in a bad `git reset` and should be have included in the previous commit.
| <!-- Project compile dependencies. --> | ||
|
|
||
| <dependency> | ||
| <groupId>com.google.guava</groupId> |
There was a problem hiding this comment.
We're probably going to want to shade this to prevent issues for users.
|
I'd rather implement ID generation using the builder pattern rather than including the static |
|
Thanks for the feedback. The only challenge I see with the custom builder is that we'd have to supply our own templates for Avro code gen so we could sneak it in to the generated class. Does that sound awful or like a reasonable solution? Or, is my OCD working overtime and it's fine for the builder to live outside of the Event class (which, admittedly, I don't like)? |
|
I'd probably have the builder live outside the |
No description provided.