Skip to content

Espace vertical du premier bloc : variante avec sidebar #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
alexisben wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Espace vertical du premier bloc : variante avec sidebar #1270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e03ade4
adjust margin top rule
alexisben Dec 1, 2025
109211b
adjustments for hero with breadcrumb
alexisben Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/sass/_theme/blocks/base.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
$backgrounded_blocks: "[class*="--accent_background"], [class*="--alt_background"], .block-timeline--horizontal, .block-pages--cards"
main
.blocks
.block:first-child:is(#{$backgrounded_blocks})
margin-top: 0
.block:last-child:is(#{$backgrounded_blocks})
margin-bottom: 0
.block:first-child:is(#{$backgrounded_blocks})
margin-top: 0

// Following chapters
.block-chapter
Expand Down
3 changes: 2 additions & 1 deletion assets/sass/_theme/design-system/hero.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
width: 100%
height: auto
@include collapsed-figcaption

.breadcrumb-nav + .content
padding-top: 0
.content + .breadcrumb-nav
Expand All @@ -55,6 +54,8 @@
position: relative
> a
@include stretched-link
&.has-breadcrumb-hero-end
padding-bottom: 0
@include media-breakpoint-down(desktop)
.content
padding-top: 0
Expand Down
13 changes: 5 additions & 8 deletions assets/sass/_theme/design-system/layout.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,14 @@ ol
> .blocks
.block:first-child
margin-top: var(--grid-gutter)

@include in-page-with-sidebar
.heading h2, .block .block-content
padding-left: offset(4)

// @include in-page-without-sidebar
// > .blocks
// .block:first-child
// &[class*="--accent_background"],
// &[class*="--alt_background"]
// margin-top: 0
.has-breadcrumb-hero-end + &
Copy link
Contributor

@Olivia206 Olivia206 Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que ça ne devrait pas être général ?

On a un cas particulier avec la config after-hero, car l'espacement respecte actuellement la hauteur du breadcrumb, ça s'espace + si on utilise cette marge sur .blocks, peut-être que c'est plutôt ça l'exception ?

en ligne :
Capture d’écran 2026-01-08 à 14 21 16

Est-ce que tu voyais d'autres cas particuliers nécessitant de bien cadrer ce style ?

@include in-page-with-sidebar
> .blocks
margin-top: var(--grid-gutter)

details
&:not([open]):hover
summary::after
Expand Down