Safari 11 bugfix: usage of promise-based version for pc.createOffer#97
Open
lawlietmester wants to merge 1 commit intootalk:masterfrom
Open
Safari 11 bugfix: usage of promise-based version for pc.createOffer#97lawlietmester wants to merge 1 commit intootalk:masterfrom
lawlietmester wants to merge 1 commit intootalk:masterfrom
Conversation
Member
|
that actually sounds like a bug in adapter. I made #98 using https://github.com/fippo/webrtc-codemods to use promises instead of the legacy version in all relevant calls |
Author
|
@fippo Maybe, but https://github.com/webrtc/adapter/issues/685
So in fact they are not supporting it |
Member
|
no, adapter shims the legacy offerToReceive constraints. I am just surprised this would not work in the callback version -- even though that should simply not be used anymore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial bug: https://github.com/andyet/SimpleWebRTC/issues/704
In case of callback-based version of
.createOfferSafari 11.0.3 perceivesmediaConstraintsalways asBut in case of promise-based version it perceives
mediaConstraintsas intended.