Fix tiling pattern and image rendering bottleneck #581
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otfried
force-pushed
the
master
branch
2 times, most recently
from
d0b335f to
a98414e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, images of large resolutions and tiling patterns render inefficiently.
See the attached ipe file, which is barely usable due to this issue.
tiling_pattern_and_image_test.ipe.zip
Image Rendering
This PR proposes using
CAIRO_FILTER_FASTinstead ofCAIRO_FILTER_GOODwhen rendering images inside the UI (but not when exporting). The visual difference is imperceptible (at least for me) and the speedup is drastic.Tiling Pattern Rendering
Currently, rendering tiling patterns (if they fill a moderately large part of the screen buffer) is painfully slow.
This is due to an apparent issue in cairo. If we do not render the tiling pattern using a repeating texture with resolution 32x32, but, say 512x512, the bottleneck disappears and rendering is orders of magnitudes faster.
To keep file exports stemming from cairo efficient (e.g., svg), only use a larger texture when drawing the ui, not exporting.