Remove import as a JS reserved word#179
Open
jackfranklin wants to merge 1 commit intoothree:masterfrom
Open
Conversation
Now that JS supports `import('/foo.js')` it shouldn't be marked as a
reserved word when used in blocks.
Owner
|
Hi, thanks for your PR. Your change can fix this issue however I don't expect it solve in this way. I will keep this reserved word and add extra def to over write it in expected context. Actually I have supported This should move to here when it got official support but I forgot to do it. You can help me update the PR to do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that JS supports
import('/foo.js')it shouldn't be marked as areserved word when used in blocks.
This is my first time changing a Vim syntax so apologies if this isn't the right fix - do let me know if you'd like me to make changes. This fixed the problem I was having locally where
importwas highlighted in red as if it were an error.