Skip to content

chore: Caddy: “when you redirect HTTP to HTTPS, always use 443”.#179

Merged
gocanto merged 1 commit intomainfrom
infra/caddy-prod
Jan 2, 2026
Merged

chore: Caddy: “when you redirect HTTP to HTTPS, always use 443”.#179
gocanto merged 1 commit intomainfrom
infra/caddy-prod

Conversation

@gocanto
Copy link
Collaborator

@gocanto gocanto commented Jan 2, 2026

Summary by CodeRabbit

  • Chores
    • Configured standard web ports (HTTP and HTTPS) for improved application deployment and accessibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@gocanto gocanto merged commit 2f68740 into main Jan 2, 2026
1 of 3 checks passed
@gocanto gocanto deleted the infra/caddy-prod branch January 2, 2026 06:44
@coderabbitai
Copy link

coderabbitai bot commented Jan 2, 2026

Caution

Review failed

The pull request is closed.

Walkthrough

This change adds explicit HTTP and HTTPS port configuration lines to the production Caddy configuration file. The global port directives specify that HTTP traffic routes through port 80 and HTTPS traffic routes through port 443, with all existing server and proxy logic remaining unchanged.

Changes

Cohort / File(s) Summary
Configuration Updates
infra/caddy/Caddyfile.prod
Added global port directives: http_port 80 and https_port 443 to explicitly configure default HTTP and HTTPS ports

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes


📜 Recent review details

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9101095 and 1237cf3.

📒 Files selected for processing (1)
  • infra/caddy/Caddyfile.prod

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist
Copy link

Summary of Changes

Hello @gocanto, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the port configuration for the Caddy web server in the production environment. By explicitly setting the "http_port" to 80 and "https_port" to 443, it clarifies the intended network listening behavior and reinforces best practices for handling HTTP to HTTPS redirects, making the setup more robust and predictable.

Highlights

  • Caddy Port Configuration: Explicitly configures Caddy to listen on standard HTTP (port 80) and HTTPS (port 443) ports in the production Caddyfile, ensuring consistent and expected behavior for web traffic and redirects.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the production Caddyfile to explicitly set the http_port and https_port global options to their standard values, 80 and 443 respectively. While these are the default values in Caddy and this change does not alter the current behavior of HTTP-to-HTTPS redirects, it improves the configuration's clarity and robustness. By making these ports explicit, the configuration is easier to understand and is protected against any potential future changes to Caddy's default port settings. The change is sound and aligns with best practices for creating explicit and maintainable configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant