Skip to content

Fixes IV calculation for AES-GCM mode#6590

Merged
dylan-conway merged 3 commits intooven-sh:mainfrom
heeeyflo:fix-aes-gcm
Oct 20, 2023
Merged

Fixes IV calculation for AES-GCM mode#6590
dylan-conway merged 3 commits intooven-sh:mainfrom
heeeyflo:fix-aes-gcm

Conversation

@heeeyflo
Copy link
Contributor

What does this PR do?

  • Code changes

This PR fixes an issue with the IV calculation that was caused by an incorrect writeUIntBE function call. It includes basic unit tests for Cipher & Decipher that cover most of the encryption modes available in Bun at the moment.

  1. IV fix comes from this PR to browserify/browserify-aes.
  2. Some of the unit tests are adapted from the nodejs/node.

How did you verify your code works?

  • I ran make js and committed the transpiled changes
  • I or my editor ran Prettier on the changed files (or I ran bun fmt)
  • I included a test for the new code, or an existing test covers it

@dylan-conway dylan-conway merged commit 7166fe1 into oven-sh:main Oct 20, 2023
@dylan-conway
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants