Conversation
Contributor
dgoerdes
commented
Jan 26, 2026
dgoerdes
commented
- switches from Oak to Hono
- build in observability
- clean up and focus on the important parts
- better docs
As it conflicts the status code 204 we do not respond with any data anymore
…tten to then update our read models
… patter as eventBus
There was a problem hiding this comment.
Pull request overview
This is a significant refactoring PR that prepares the Nimbus framework for a 1.0 release. The main changes include:
Changes:
- Switches HTTP adapter from Oak to Hono for better performance and broader runtime support
- Introduces built-in observability with OpenTelemetry tracing and metrics throughout the framework
- Simplifies core architecture by removing complex router patterns and introducing cleaner message-based APIs
- Updates dependency versions (MongoDB 7.0.0, Zod 4.3.5) and refactors exception naming
Reviewed changes
Copilot reviewed 154 out of 156 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/oak/* | Complete removal of Oak HTTP framework integration |
| packages/hono/* | New Hono adapter with correlation ID, logger middleware, and error handler |
| packages/mongodb/src/lib/tracing.ts | New OpenTelemetry tracing wrapper for MongoDB operations |
| packages/mongodb/src/lib/crud/* | All CRUD operations now wrapped with tracing spans |
| packages/core/src/lib/message/* | New simplified Command, Query, Event types following CloudEvents spec |
| packages/core/src/lib/eventBus/eventBus.ts | Rewritten EventBus with exponential backoff and observability |
| packages/core/src/lib/message/router.ts | New MessageRouter replacing old router implementation |
| packages/core/src/lib/exception/* | Exception name changes (e.g., NOT_FOUND_EXCEPTION → NOT_FOUND) |
| examples/the-expense/* | Complete removal of old example application |
| examples/hono-demo/* | New comprehensive example using Hono and new architecture |
| docs/* | Extensive documentation updates covering all new features |
Files not reviewed (1)
- docs/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| state = addUser(state, command); | ||
|
|
||
| if (state) { |
There was a problem hiding this comment.
This use of variable 'state' always evaluates to true.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.