[ Refresh-app ] Fix cache busting#97
Open
Armored-Dragon wants to merge 1 commit intooverte-org:masterfrom
Open
[ Refresh-app ] Fix cache busting#97Armored-Dragon wants to merge 1 commit intooverte-org:masterfrom
Armored-Dragon wants to merge 1 commit intooverte-org:masterfrom
Conversation
Changed part of the URL used for busting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Refresh-app uses the query part of a url in order to take advantage of cache busting. This method does not seem to work with every server setup. This pull changes the part of the url that is used for cache busting to the fragment.
In effect this changes the symbol from "?" to "#".
Fixes #30.
This has a big "Works on my machine" disclaimer. Testing these changes will be highly appreciated. This has been tested against my private server, along with the Overte content server and the app appears to be functional.