-
Notifications
You must be signed in to change notification settings - Fork 4
DIGIT-2292 Enhance the web index html from parsec flutter #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Victorcorcos
merged 66 commits into
oxeanbits:main
from
Victorcorcos:enhance-web-example-ui
Sep 7, 2025
Merged
DIGIT-2292 Enhance the web index html from parsec flutter #35
Victorcorcos
merged 66 commits into
oxeanbits:main
from
Victorcorcos:enhance-web-example-ui
Sep 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent solutions
…aring them directly
…/native delegation
…ancing approach throughout the codebase.
…m Emscripten run Remove **/wasm/** from .gitignore + Send javascript file resulted from Emscripten run
…lted from Emscripten run" This reverts commit a4842d3.
…n; export exception symbol - README: add Web testing commands and CI notes - pubspec: mention Web platform and add dev dependency on web - platform_interface: export ParsecEvalException for consumers Improves discoverability and setup for Web testing and consumption.
- Covers arithmetic, trig, hyperbolic, logs/exp, strings, booleans, comparisons, ternary, advanced functions, and performance - Serves as the primary WASM-backed test harness for Chrome Ensures broad coverage of the web plugin behavior.
Replace shell script approach with native Dart command for generating WebAssembly files. This provides a more maintainable, cross-platform solution that integrates better with Flutter development workflows. - Add parsec_web/bin/generate.dart with comprehensive WASM generation - Configure executable in pubspec.yaml for easy access - Include Emscripten availability checking and error handling - Provide user-friendly output with progress indicators and next steps - Support building from 38 C++ source files to single WASM bundle
Modernize continuous integration workflows to use the new Dart-based WebAssembly generation command instead of shell scripts. - Replace shell script calls with 'dart bin/generate.dart' in web_tests.yml - Remove redundant WebAssembly build step to avoid duplication - Add parsec_web analysis step to flutter_ci.yml for complete coverage - Maintain all existing test functionality while improving maintainability
Remove setup_web_assets.sh script that is no longer needed after implementing the new Dart-based WebAssembly generation command. The new 'dart bin/generate.dart' command provides all the functionality of this script with better error handling, cross-platform support, and integration with Flutter development workflows.
Update all documentation to reflect the new Dart-based WebAssembly generation workflow, replacing references to obsolete shell scripts. - Replace './setup_web_assets.sh' with 'dart bin/generate.dart' in README - Add comprehensive web platform development section to CLAUDE.md - Include Emscripten installation instructions and development workflow - Update example README with clear native vs web platform instructions - Improve troubleshooting sections with modern command references
…tory as recommended by @rodiguif for publishing to pub.dev
Victorcorcos
added a commit
to Victorcorcos/parsec_flutter
that referenced
this pull request
Sep 7, 2025
The enhanced index.html with loading UI and WebAssembly integration has been moved to PR oxeanbits#35 to keep this PR focused on the core Dart-based WASM generation infrastructure.
Victorcorcos
added a commit
to Victorcorcos/parsec_flutter
that referenced
this pull request
Sep 7, 2025
…eanbits#35)" This reverts commit 3dd5ae2.
Victorcorcos
added a commit
that referenced
this pull request
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a comprehensive web example interface that demonstrates the parsec_web WebAssembly integration with a polished user experience with improved loading UI.
Key Features
Technical Implementation
<script type="module">for parsec-web JavaScript wrapper to support ES6 exportswindow.parsecWebReady) before Flutter app startupFile Structure
Test Plan
To verify this enhancement works correctly:
cd parsec_web && dart bin/generate.dartcd parsec/example && flutter run -d chromeDependencies
This enhancement depends on the parsec_web package structure with:
packages/parsec_web/parsec-web/js/equations_parser_wrapper.js(ES6 module)dart bin/generate.dartBreaking Changes
None. This is a new file that enhances the existing web example without affecting other platforms or core functionality.