Skip to content

Refactor body scrollbars into external wrapper #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mrprey wants to merge 1 commit into from
Closed

Refactor body scrollbars into external wrapper #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/pluto_grid.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ class PlutoGridState extends PlutoStateWithChange<PlutoGrid> {
/// Body columns and rows.
LayoutId(
id: _StackName.bodyRows,
child: PlutoBodyRows(_stateManager),
child: PlutoBodyRowsWithScrollbar(_stateManager),
),
LayoutId(
id: _StackName.bodyColumns,
Expand Down
142 changes: 88 additions & 54 deletions lib/src/ui/pluto_body_rows.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,69 +4,45 @@ import 'package:pluto_grid/pluto_grid.dart';
import '../helper/platform_helper.dart';
import 'ui.dart';

class PlutoBodyRows extends PlutoStatefulWidget {
class PlutoBodyRowsWithScrollbar extends StatefulWidget {
final PlutoGridStateManager stateManager;

const PlutoBodyRows(
const PlutoBodyRowsWithScrollbar(
this.stateManager, {
super.key,
});

@override
PlutoBodyRowsState createState() => PlutoBodyRowsState();
State<PlutoBodyRowsWithScrollbar> createState() =>
_PlutoBodyRowsWithScrollbarState();
}

class PlutoBodyRowsState extends PlutoStateWithChange<PlutoBodyRows> {
List<PlutoColumn> _columns = [];

List<PlutoRow> _rows = [];

class _PlutoBodyRowsWithScrollbarState
extends State<PlutoBodyRowsWithScrollbar> {
late final ScrollController _verticalScroll;

late final ScrollController _horizontalScroll;

@override
PlutoGridStateManager get stateManager => widget.stateManager;

@override
void initState() {
super.initState();

_horizontalScroll = stateManager.scroll.horizontal!.addAndGet();

stateManager.scroll.setBodyRowsHorizontal(_horizontalScroll);

_verticalScroll = stateManager.scroll.vertical!.addAndGet();

stateManager.scroll.setBodyRowsVertical(_verticalScroll);

updateState(PlutoNotifierEventForceUpdate.instance);
}

@override
void dispose() {
_verticalScroll.dispose();

_horizontalScroll.dispose();

super.dispose();
}

@override
void updateState(PlutoNotifierEvent event) {
forceUpdate();

_columns = _getColumns();

_rows = stateManager.refRows;
}

List<PlutoColumn> _getColumns() {
return stateManager.showFrozenColumn == true
? stateManager.bodyColumns
: stateManager.columns;
}

@override
Widget build(BuildContext context) {
final scrollbarConfig = stateManager.configuration.scrollbar;
Expand All @@ -90,30 +66,88 @@ class PlutoBodyRowsState extends PlutoStateWithChange<PlutoBodyRows> {
radius: scrollbarConfig.scrollbarRadius,
radiusWhileDragging: scrollbarConfig.scrollbarRadiusWhileDragging,
longPressDuration: scrollbarConfig.longPressDuration,
child: SingleChildScrollView(
controller: _horizontalScroll,
scrollDirection: Axis.horizontal,
physics: const ClampingScrollPhysics(),
child: CustomSingleChildLayout(
delegate: ListResizeDelegate(stateManager, _columns),
child: ListView.builder(
controller: _verticalScroll,
scrollDirection: Axis.vertical,
physics: const ClampingScrollPhysics(),
itemCount: _rows.length,
itemExtent: stateManager.rowTotalHeight,
addRepaintBoundaries: false,
itemBuilder: (ctx, i) {
return PlutoBaseRow(
key: ValueKey('body_row_${_rows[i].key}'),
rowIdx: i,
row: _rows[i],
columns: _columns,
stateManager: stateManager,
visibilityLayout: true,
);
},
),
child: PlutoBodyRows(
stateManager,
verticalScroll: _verticalScroll,
horizontalScroll: _horizontalScroll,
),
);
}
}

class PlutoBodyRows extends PlutoStatefulWidget {
final PlutoGridStateManager stateManager;

final ScrollController verticalScroll;

final ScrollController horizontalScroll;

const PlutoBodyRows(
this.stateManager, {
required this.verticalScroll,
required this.horizontalScroll,
super.key,
});

@override
PlutoBodyRowsState createState() => PlutoBodyRowsState();
}

class PlutoBodyRowsState extends PlutoStateWithChange<PlutoBodyRows> {
List<PlutoColumn> _columns = [];

List<PlutoRow> _rows = [];

@override
PlutoGridStateManager get stateManager => widget.stateManager;

@override
void initState() {
super.initState();

updateState(PlutoNotifierEventForceUpdate.instance);
}

@override
void updateState(PlutoNotifierEvent event) {
forceUpdate();

_columns = _getColumns();

_rows = stateManager.refRows;
}

List<PlutoColumn> _getColumns() {
return stateManager.showFrozenColumn == true
? stateManager.bodyColumns
: stateManager.columns;
}

@override
Widget build(BuildContext context) {
return SingleChildScrollView(
controller: widget.horizontalScroll,
scrollDirection: Axis.horizontal,
physics: const ClampingScrollPhysics(),
child: CustomSingleChildLayout(
delegate: ListResizeDelegate(stateManager, _columns),
child: ListView.builder(
controller: widget.verticalScroll,
scrollDirection: Axis.vertical,
physics: const ClampingScrollPhysics(),
itemCount: _rows.length,
itemExtent: stateManager.rowTotalHeight,
addRepaintBoundaries: false,
itemBuilder: (ctx, i) {
return PlutoBaseRow(
key: ValueKey('body_row_${_rows[i].key}'),
rowIdx: i,
row: _rows[i],
columns: _columns,
stateManager: stateManager,
visibilityLayout: true,
);
},
),
),
);
Expand Down