[reconfigurator-cli] Fixes and improvements for RoT update testing#8904
Merged
karencfv merged 13 commits intooxidecomputer:mainfrom Aug 27, 2025
Merged
[reconfigurator-cli] Fixes and improvements for RoT update testing#8904karencfv merged 13 commits intooxidecomputer:mainfrom
karencfv merged 13 commits intooxidecomputer:mainfrom
Conversation
jgallagher
reviewed
Aug 26, 2025
karencfv
commented
Aug 26, 2025
Contributor
Author
karencfv
left a comment
karencfv
left a comment
There was a problem hiding this comment.
Thanks for taking a look!
karencfv
commented
Aug 26, 2025
Contributor
Author
karencfv
left a comment
karencfv
left a comment
There was a problem hiding this comment.
I think I've addressed all of the comments, please let me know if there's anything missing @jgallagher!
Contributor
Author
|
Alright! I think I've got everything now! Thanks for holding your ground @jgallagher 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8893