[rfd-599] Implement skeleton external subnets API #9638
+33,469
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using jj-spr 0.1.0
Created using jj-spr 0.1.0 [skip ci]
Created using jj-spr 0.1.0
mergeconflict
assigned
rcgoodfellow and
bnaecker and unassigned
rcgoodfellow and
bnaecker
bnaecker
reviewed
Jan 14, 2026
Collaborator
bnaecker
left a comment
bnaecker
left a comment
There was a problem hiding this comment.
This all looks pretty good! I just have one substantive suggestion to strengthen the types around creating subnets, but otherwise seems like a solid start.
Created using jj-spr 0.1.0 [skip ci]
Created using jj-spr 0.1.0
Created using jj-spr 0.1.0 [skip ci]
Created using jj-spr 0.1.0 [skip ci]
Created using jj-spr 0.1.0 [skip ci]
Created using jj-spr 0.1.0
Created using jj-spr 0.1.0 [skip ci]
Created using jj-spr 0.1.0
Created using jj-spr 0.1.0 [skip ci]
…david-crespo's feedback Created using jj-spr 0.1.0
Created using jj-spr 0.1.0 [skip ci]
mergeconflict
added a commit
that referenced
this pull request
Jan 17, 2026
…ernal API (#9669) From discussion in #9638 (comment), we decided that `AddressSelector` is a bit of a misnomer in our current scheme, where "selector" implies filtering/fetching from existing resources. We'll use `AddressAllocator` instead, which better describes the action of reserving/assigning a floating IP address from a pool. I've also done a bit of refactoring here to be more RFD 619 friendly. Before this PR, we had a series of `FloatingIpCreate` versions that each had `From` or `TryFrom` conversions directly to the latest API version in "big step" style. This becomes an _O(n)^2_ problem to maintain over time. Instead, in this PR, we convert to "small step" style, where each older version of `FloatingIpCreate` converts to the next newer version. In the terms of the RFD, we "[hop through intermediate versions](https://rfd.shared.oxide.computer/rfd/0619#determinations-one-prior-version)." This ensures that the next time we change `FloatingIpCreate`, we only need to introduce one new conversion, rather than update all older conversions. I've added proptests to make our expectations of the conversion behavior more explicit and prevent regressions.
Created using jj-spr 0.1.0 [skip ci]
mergeconflict
changed the base branch from
spr/mergeconflict/main.rfd-599-implement-skeleton-external-subnets-api
to
spr/mergeconflict/rfd-599-implement-skeleton-subnet-pools-api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #9634, this PR implements a skeleton
/v1/external-subnetsREST API for allocating external subnets from subnet pools, and attaching them to instances, as described in RFD 599.