Enable wicket / config-rss.toml to configure the rack subnet #9653
Conversation
internet-diglett
changed the title
jgallagher
left a comment
jgallagher
left a comment
There was a problem hiding this comment.
Looks reasonable to me - just a couple minor questions.
Have you given this a spin on a racklette? (Can we, before merging?)
| if rack_subnet_address.octets()[6] == 0x00 { | ||
| return Err("rack number (seventh octet) cannot be 0".into()); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Do we want to check that the low 72 bits are all 0? That's guaranteed for our random ones, and converting the subnet address into an Ipv6Net<56> will do that, but it may indicate some confusion if an operator asks for it?
There was a problem hiding this comment.
I think that's a reasonable check to add, as it does make things a bit clearer in terms of what we expect (and what the system will do if you set the lower bits of the address)
| rack_network_config.as_ref().map_or("".into(), |c| { | ||
| match c.rack_subnet_address { | ||
| Some(v) => v.to_string(), | ||
| None => "".to_string(), |
There was a problem hiding this comment.
Do we want something like "(will be chosen randomly)" instead of leaving it blank?
There was a problem hiding this comment.
I think this is also a good idea
I'll do that today! |
Related
#9501