[refactor,nexus,mcast] delegate versioned multicast endpoints using Path::map #9658
+88
−257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ath::map Since Dropshot's Path extractor has a `map` method, we can delegate most versioned multicast endpoints inline in the trait definition (lib.rs) instead of maintaining separate implementations in `http_entrypoints.rs`. Delegated endpoints: - v2025121200_multicast_group_view - v2025121200_multicast_group_member_list - v2025121200_instance_multicast_group_leave - v2025121200_lookup_multicast_group_by_ip
mergeconflict
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Dropshot's Path extractor has a
mapmethod (0.16.6), we can delegate most versioned multicast endpoints inline in the trait definition (lib.rs) instead of maintaining separate implementations inhttp_entrypoints.rs.Delegated endpoints:
This also makes conversions in lib.rs more concise, thanks @mergeconflict.