Don't panic on json-body failure #1244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently CLI clients will panic if the `json-body` file cannot be read or cannot be deserialized. Update these to return errors and add additional context.
wfchandler
force-pushed
the
wc/handle-json-failure
branch
from
86fb5e1 to
253437e
Compare
ahl
approved these changes
Nov 13, 2025
progenitor-impl/src/cli.rs
Outdated
| &body_txt, | ||
| ) | ||
| .unwrap(); | ||
| .with_context(|| format!("failed to deserialize {} as JSON", value.display()))?; |
Collaborator
There was a problem hiding this comment.
we could probably make this message more accurate
Contributor
Author
There was a problem hiding this comment.
I made the message a bit simpler, and hopefully easier for users to follow.
abus-sh
pushed a commit
to abus-sh/progenitor
that referenced
this pull request
Dec 5, 2025
Currently CLI clients will panic if the `json-body` file cannot be read or cannot be deserialized. Update these to return errors and add additional context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CLI clients will panic if the
json-bodyfile cannot be read or cannot be deserialized.Update these to return errors and add additional context.