Skip to content

PHD: make lshw_lifecycle_test actually do that on Alpine #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hawkw wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

PHD: make lshw_lifecycle_test actually do that on Alpine #1037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions phd-tests/tests/src/hw.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ use phd_testcase::*;

#[phd_testcase]
async fn lspci_lifecycle_test(ctx: &Framework) {
const LSPCI: &str = "sudo lspci -vvx";
const LSHW: &str = "sudo lshw -notime";
const LSPCI: &str = "lspci -vvx";
Copy link
Member

@iximeow iximeow Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so the real trick here is that i don't think there is an lspci (or lshw) in the Alpine image, at least the oldish 3.20 image i've got just says -ash: lshw: not found and the same for lspci. since the output can vary by distro's choice and version of the tools, i think we don't want to just compare to a golden output

i'm pretty sure this is actually why i'd wanted to get #797 in, because the sign that this output is uninformative is, i think, getting a non-zero status.

Copy link
Member Author

@hawkw hawkw Feb 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. we should really try and pick #797 back up, this is a very unfortunate situation.

const LSHW: &str = "lshw -notime";

let mut vm = ctx
.spawn_vm(&ctx.vm_config_builder("lspci_lifecycle_test"), None)
Expand Down
Loading