viona: do not retain peak nqueues across device reset #1051
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 9, 2026
dancrossnyc
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1df49a4, also, was too eager to reset viona rings. the issue here is more subtle.
the "peak" count for used virtqueues was retained across device resets, so if a guest ever negotiates multiqueue, resets the NIC as for reboot (where we SET_PAIRS down to 1), and then does a virtio reset with the
device_statusregister, we'll try to reset all queues even though the pairs after 1 are not actually in use. this EINVAL's and we get the device intoNEEDS_RESET.