Skip to content

chore: remove redundant pattern #956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ahl merged 1 commit into from
Jan 10, 2026
Merged

chore: remove redundant pattern #956

ahl merged 1 commit into from
Jan 10, 2026

Conversation

@ericszentivanyi
Copy link
Contributor

@ericszentivanyi ericszentivanyi commented Jan 8, 2026 •
edited
Loading

This pattern is now handled by syn’s accept_as_ident function.

See: https://github.com/dtolnay/syn/blob/fa9129fe5f76a0dd3fa89c3e62b5a20a4190e8cc/src/ident.rs#L64

@ahl
Copy link
Collaborator

ahl commented Jan 10, 2026

Thanks for this.

@ahl ahl merged commit f0bcf00 into oxidecomputer:main Jan 10, 2026
4 checks passed
@ericszentivanyi ericszentivanyi deleted the chore/redundant-pattern branch January 11, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahl ahl ahl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ericszentivanyi @ahl