Skip to content

feat(async search): handle partial response#335

Merged
forshev merged 1 commit intomainfrom
0-async-search-partial-response
Feb 6, 2026
Merged

feat(async search): handle partial response#335
forshev merged 1 commit intomainfrom
0-async-search-partial-response

Conversation

@forshev
Copy link
Contributor

@forshev forshev commented Jan 30, 2026

Description

Add partial response behavior to async search similar to sync search


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@github-actions
Copy link
Contributor

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
Bitmask-4 174405 19fc09
0.00 B/op 3.00 B/op NaN 🔴
FindSequence_Random/small-4 174405 19fc09
10280.15 MB/s 3107.07 MB/s 0.30 🔴
24.90 ns/op 82.39 ns/op 3.31 🔴
GenerateDocs-4 174405 19fc09
952.20 ns/op 1099.00 ns/op 1.15 🔴
ProcessDocuments-4 174405 19fc09
381.00 B/op 32569.00 B/op 85.48 🔴

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 20.37037% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.47%. Comparing base (faf8405) to head (b0f123d).

Files with missing lines Patch % Lines
proxyapi/grpc_async_search.go 0.00% 24 Missing ⚠️
proxy/search/async.go 36.66% 13 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   71.61%   71.47%   -0.14%     
==========================================
  Files         204      204              
  Lines       14823    14857      +34     
==========================================
+ Hits        10615    10619       +4     
- Misses       3447     3474      +27     
- Partials      761      764       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eguguchkin eguguchkin requested review from cheb0 and moflotas January 30, 2026 13:41
@eguguchkin eguguchkin added this to the v0.66.0 milestone Jan 30, 2026
@forshev forshev force-pushed the 0-async-search-partial-response branch from 4937000 to b0f123d Compare February 6, 2026 08:34
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2026

🔴 Performance Degradation

Some benchmarks have degraded compared to the previous run.
Click on Show table button to see full list of degraded benchmarks.

Show table
Name Previous Current Ratio Verdict
FindSequence_Random/medium-4 faf840 fe7aa3
9992.82 MB/s 6808.49 MB/s 0.68 🔴
102.50 ns/op 150.40 ns/op 1.47 🔴

@forshev forshev merged commit 6ae5683 into main Feb 6, 2026
11 of 12 checks passed
@forshev forshev deleted the 0-async-search-partial-response branch February 6, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants