Add File Explorer screen for selecting Bitcoin config file#8
Add File Explorer screen for selecting Bitcoin config file#8pool2win merged 6 commits intop2poolv2:mainfrom
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
pool2win
left a comment
There was a problem hiding this comment.
Generally looks good, but we are missing unit tests and comments on structs and functions.
pool2win
left a comment
There was a problem hiding this comment.
Looking much better now. Writing comments and unit tests is even more important in the LLM era, these help LLMs write better code and detect errors.
Next thing. If you look at the codecov report you can see we are missing coverage on 17 lines, if you dig into the report https://app.codecov.io/gh/p2poolv2/pdm/pull/8?src=pr&el=tree you can see that it is because we haven't written tests for a) wrapping around the index and b) setting selected field. Please add tests to cover those cases too.
Added |
pool2win
left a comment
There was a problem hiding this comment.
The codecov report still is below 90% for the file_explorer module. The parts about going to parent directory are untested. https://app.codecov.io/gh/p2poolv2/pdm/pull/8?src=pr&el=tree#fb36e13b4d2998c3c08398594680d935-R105 Let's add tests for those.
Changes:
Interaction flow: