P2Pool Config Integration. by R27-pixel · Pull Request #9 · p2poolv2/pdm

R27-pixel · 2026-01-04T17:11:18Z

P2Pool Config Integration and config tests

codecov · 2026-01-04T17:12:27Z

Codecov Report

❌ Patch coverage is 97.63092% with 19 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/main.rs	95.87%	8 Missing ⚠️
src/components/config_editor.rs	96.71%	5 Missing ⚠️
src/components/legacy_p2pool_parser.rs	85.71%	5 Missing ⚠️
src/ui.rs	98.21%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

pool2win

Nice start. Left some comments. We need to use rust's config.rs so we don't end up writing parsing code. Also, ratatui navigation block is becoming too big, please check if we can compose that somehow from sub sections.

pool2win · 2026-01-08T10:56:01Z

src/components/config_editor.rs

Add comments to all functions.

pool2win · 2026-01-08T10:57:30Z

src/components/p2pool_parser.rs

Rename to p2poolv2_config_parser.rs

Use config.rs crate and we won't have to do string split on = to get key/value pairs. We will also get the sections.

See how we do it here: https://github.com/p2poolv2/p2poolv2/blob/main/p2poolv2_lib/src/config.rs

pool2win · 2026-01-08T11:07:51Z

src/main.rs

-                            // File Selected!
-                            app.bitcoin_conf_path = Some(path);
-                            app.toggle_menu(); // Go back to main screen
+                        if let Some(path) = app.explorer.select().filter(|p| p.is_file()) {


I have a fear this navigation is going to become a HUGE case statement. Can we compose this from smaller case statements per section? See if ratatui provides support for this.

pool2win

It is a large PR. It'll be really nice to split it into two. UI changes with the refactors you mentioned and one for reading/updating/writing config file.

We also need to clean up the legacy config format. We never used it in p2pool. IDK why you have that here TBH.

pool2win · 2026-01-14T14:41:14Z

src/components/legacy_p2pool_parser.rs

+use super::p2poolv2_config_parser::{ConfigField, ConfigSection};
+
+/// Parses legacy p2pool.conf (key=value) format into UI sections
+pub fn parse_legacy_p2pool_conf<P: AsRef<Path>>(path: P) -> io::Result<Vec<ConfigSection>> {


What is the legacy conf?

i added this because one test was failing maybe when a non-toml file was selected, so i intriduced key=value parser to make the test pass.
and yeah the fallback dosent correspond to the real config format, i just introduced to make the test pass
ill make it strictly TOML/schema-driven

the test case is wrong , and because of it i had to add it just to make it pass . ill remove it .
thanks

pool2win · 2026-01-14T14:42:25Z

src/components/p2poolv2_config_parser.rs

+pub fn parse_p2poolv2_config<P: AsRef<Path>>(path: P) -> io::Result<Vec<ConfigSection>> {
+    let path = path.as_ref();
+
+    // Try TOML first


We only have toml config files, so no need to fall back to legacy. Lets clean that up.

pool2win · 2026-01-14T14:43:13Z

src/components/p2poolv2_config_parser.rs

+use crate::components::p2poolv2_config_schema::Config;
+
+#[derive(Clone, Debug, PartialEq)]
+pub struct ConfigField {


Since we only have toml config file, I think we might also not need this struct.

pool2win · 2026-01-14T14:59:12Z

Interesting. If someone selects a non-toml file, the config.rs parser will raise an error. We should depend on the error and show a meaningful error to the user.

…

On Wed, 14 Jan 2026 at 15:57, R27 ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/components/legacy_p2pool_parser.rs <#9 (comment)>: > @@ -0,0 +1,56 @@ +// SPDX-FileCopyrightText: 2024 PDM Authors +// SPDX-License-Identifier: AGPL-3.0-or-later + +use std::fs::File; +use std::io::{self, BufRead}; +use std::path::Path; + +use super::p2poolv2_config_parser::{ConfigField, ConfigSection}; + +/// Parses legacy p2pool.conf (key=value) format into UI sections +pub fn parse_legacy_p2pool_conf<P: AsRef<Path>>(path: P) -> io::Result<Vec<ConfigSection>> { i added this because one test was failing maybe when a non-toml file was selected, so i intriduced key=value parser to make the test pass. and yeah the fallback dosent correspond to the real config format, i just introduced to make the test pass ill make it strictly TOML/schema-driven — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ASU3SYKKSPFC2XRSG7QELA34GZKNNAVCNFSM6AAAAACQU6VLHCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNRRGE3TINJXG4> . You are receiving this because you commented.Message ID: ***@***.***>

R27-pixel · 2026-01-14T15:03:26Z

Interesting. If someone selects a non-toml file, the config.rs parser will raise an error. We should depend on the error and show a meaningful error to the user.
…
On Wed, 14 Jan 2026 at 15:57, R27 @.> wrote: @.* commented on this pull request. ------------------------------ In src/components/legacy_p2pool_parser.rs <#9 (comment)>: > @@ -0,0 +1,56 @@ +// SPDX-FileCopyrightText: 2024 PDM Authors +// SPDX-License-Identifier: AGPL-3.0-or-later + +use std::fs::File; +use std::io::{self, BufRead}; +use std::path::Path; + +use super::p2poolv2_config_parser::{ConfigField, ConfigSection}; + +/// Parses legacy p2pool.conf (key=value) format into UI sections +pub fn parse_legacy_p2pool_conf<P: AsRef>(path: P) -> io::Result<Vec> { i added this because one test was failing maybe when a non-toml file was selected, so i intriduced key=value parser to make the test pass. and yeah the fallback dosent correspond to the real config format, i just introduced to make the test pass ill make it strictly TOML/schema-driven — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASU3SYKKSPFC2XRSG7QELA34GZKNNAVCNFSM6AAAAACQU6VLHCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMNRRGE3TINJXG4 . You are receiving this because you commented.Message ID: @.***>

Got it
I’ll remove the fallback and make the UI depend on config.rs errors and givea proper validation error to the user instead.

R27-pixel marked this pull request as draft January 4, 2026 17:13

R27-pixel marked this pull request as ready for review January 8, 2026 10:31

pool2win reviewed Jan 8, 2026

View reviewed changes

pool2win requested changes Jan 14, 2026

View reviewed changes

R27-pixel closed this Jan 15, 2026

R27-pixel force-pushed the feature/p2pool-config branch from e5ca31d to dafc799 Compare January 15, 2026 08:04

R27-pixel deleted the feature/p2pool-config branch January 15, 2026 08:08

R27-pixel restored the feature/p2pool-config branch January 18, 2026 06:59

Comments

Conversation

R27-pixel commented Jan 4, 2026

Uh oh!

codecov bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pool2win left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pool2win left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pool2win commented Jan 14, 2026 via email

Uh oh!

R27-pixel commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jan 4, 2026 •

edited

Loading

pool2win left a comment •

edited

Loading