fixes #25 #28
Open
fixes #25 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to disable Husky since it prevented me from committing (there seems to be issues with test scripts and other stuff as well, for this repository).
The tiny changes is mainly in these two files:
Your authorization endpoint returns a hostname, which seems to be required in ApiRequest (src/api/ApiMethod.js). The changes I've made, forwards the hostname value in order resolve the API request.
Finally, I tried to add a hostname prompt to
https://github.com/pCloud/pcloud-sdk-js/blob/master/examples/node/token.jsbut that file does not to work at all, before any changes.