formatting streamflow extreme data for PCEX #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corviday
changed the title
eyvorchuk
reviewed
May 16, 2023
Contributor
eyvorchuk
left a comment
eyvorchuk
left a comment
There was a problem hiding this comment.
Looks mostly straightforward, but I have a few questions.
| assert end_date.month == 12 and end_date.day == 31, "This script assumes climatologies that end Dec 31: {}".format(end_date) | ||
| start_year = (start_date.year - ref_date.year) * 365 | ||
| end_year = (end_date.year - ref_date.year) * 365 | ||
| outfile.variables["time_bnds"][:] = np.array([[start_year + 1, end_year + 365]]) |
Contributor
There was a problem hiding this comment.
I might be misunderstanding how climatology bounds work, but if for example, the ref_date is 1950-01-01, the start_date is 1950-01-01, and the end_date is 1950-12-31, would the time_bnds then be [0, 364] instead of [1, 365]?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting files and procedures for the new MOTI data.
update_metadata(over 50 this time!)time_bndsvariable to a climatological annual data set that hasn't got onetimedata.