Skip to content

Conversation

@wizrds
Copy link
Contributor

@wizrds wizrds commented Jan 26, 2026

This pull request exposes the ProxySettings struct to the BrowserContextOptions to support specifying proxy options when creating a new context.

@padamson
Copy link
Owner

Thanks for this contribution! The implementation looks good and matches the Playwright API.

A few changes I'll make before merging:

  1. Breaking change: The removal of ProxySettings from api::launch_options could break existing users--adding a re-export in api/mod.rs for backward compatibility.

  2. Tests: Adding a basic test to verify the proxy option serializes correctly

Otherwise, this looks ready to merge

@padamson padamson enabled auto-merge (squash) January 26, 2026 12:37
@padamson padamson merged commit 26b80c9 into padamson:main Jan 26, 2026
3 checks passed
@wizrds wizrds deleted the fix/proxy-browser-opts branch January 27, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants