Skip to content
This repository was archived by the owner on Oct 28, 2019. It is now read-only.

fix: Firebase.Database.Snapshot.exists function does not exists#31

Open
nattster wants to merge 2 commits intopairshaped:masterfrom
nattster:master
Open

fix: Firebase.Database.Snapshot.exists function does not exists#31
nattster wants to merge 2 commits intopairshaped:masterfrom
nattster:master

Conversation

@nattster
Copy link
Contributor

  1. Map Firebase.Database.Snapshot.exists to correct native function
  2. Return boolean result from .exists() directly. Returning { ctor: "False" } evaluates to True in elm 0.18.0

@mrozbarry
Copy link
Contributor

@nattster have you tested this, and it's working as expected?

@jjant
Copy link

jjant commented May 31, 2018

@mrozbarry I made the same change on my local package dir to fix this

@SidneyNemzer
Copy link

Just got a runtime error because Firebase.Database.Snapshot.exists maps to Native.Database.exists, but that's not actually a function. @mrozbarry it would be awesome if you could merge this!

@SidneyNemzer
Copy link

Just an update, we've merged this PR into our fork here: https://github.com/ucode/elm-firebase

We'll be happy to merge PRs there, if anyone else finds bugs to fix!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants