Open
Conversation
Wondering why everyone is mixing up the <h3> and <li> tag's in HTML, you need to close the tags following the order hierarchy Wouldn't we be closing the tags like this? <h3> <li> </li> </h3> If you just want to increase the font size of the list elements I think it makes sense to create a CSS class and use that instead of using an <h3> tag, Since it is bad practice. This can cause accessibility issues to arise when someone is using a screen reader software. As screen reading software organizes and reads Your text based on the Heading tag hierarchy. Here is an example of what I mean. <li class="font-large">My name is Rehman, and my profile link is ... </li> I've created the CSS class and submitted a pull request with these suggested changes. I hope someone else can follow through as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.