TYP: DataFrame.__setitem__ with None
#1550
Open
+82
−153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmp0xff
force-pushed
the
feature/setitem-none
branch
from
6f392cb to
746c760
Compare
cmp0xff
commented
Dec 15, 2025
Comment on lines
430
to
434
| df.loc[:, ["x"]] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index] | ||
| df.iloc[:, [0]] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index] | ||
|
|
||
| df.loc[:, iter(["x"])] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index] | ||
| df.iloc[:, iter([0])] = [[None], [pd.NA], [pd.NaT]] # type: ignore[assignment,index] |
Contributor
Author
There was a problem hiding this comment.
Not too sure why they don't work for mypy
Member
There was a problem hiding this comment.
@Dr-Irv any insights on this one? I tried and got the same error.
Collaborator
There was a problem hiding this comment.
It's a mypy bug and a difference between the pyright setting of strictListInference, which we have turned on because we are using pyright in strict mode.
I created python/mypy#20420
Can you add a comment referring to the above issue for those tests?
Contributor
Author
Comment on lines
+94
to
+95
| df[["col1"]] = [[None], [pd.NA]] # type: ignore[assignment,list-item] | ||
| df[iter(["col1"])] = [[None], [pd.NA]] # type: ignore[assignment] |
Contributor
Author
There was a problem hiding this comment.
Not too sure why they don't work for mypy
loicdiridollou
approved these changes
Dec 15, 2025
Member
loicdiridollou
left a comment
loicdiridollou
left a comment
There was a problem hiding this comment.
Will approve preemptively, just one question for @Dr-Irv and then we should be good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__setitem__should accept sequences containing None? #1538assert_type()to assert the type of any return value)AGENTS.md.