-
Notifications
You must be signed in to change notification settings - Fork 12
Resizable UI #649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Endaris
wants to merge
50
commits into
panel-attack:beta
Choose a base branch
from
Endaris:resizableUi
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Resizable UI #649
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
552ccff
add layouting logic and adapt it for UiElement
Endaris 130bae5
make specialized scrollcontainer to replace Menu
Endaris 28d3541
some layouting adjustments for options menu
Endaris 91bf458
fully replace Menu with new ScrollContainer-based VerticalMenu
Endaris 2187846
rework font handling to work with discrete key sizes
Endaris 8f7ea94
add adaptive layout and fix some more font stuff
Endaris 13efcce
fix a crash, fix graphics menu adjustment, fix slider alignment
Endaris e9c22b6
refix slider positioning
Endaris ed0dcce
vaguely resolve most crashes for a slightly broken layout (lobby/vsSelf)
Endaris b8f5b52
add a static layout that blocks flex propagation
Endaris 8dcd4ff
adjust layouting to use a UIElement specific baseWidth/Height
Endaris 1a53bdc
add shrinking to horizontalFlexLayout
Endaris 1493e6f
abandon fixed canvas resolution, embrace dynamic window size
Endaris 9e6c122
add a very basic standard cursor for whatever needs to kickstart a ne…
Endaris 6bbb45b
initial cursor display for designhelper
Endaris c910910
create a container that unifies child size allows grid size navigatio…
Endaris 3da0250
Merge branch 'beta' into resizableUi
Endaris 0728309
fix most things about wrapping containers with children
Endaris a84081b
fix scene.uiRoot maximum dimensions
Endaris f02c6e5
change alignment options to be parent based
Endaris d4f47d5
fix alignment for unisizedcontainer children and default to minWidth …
Endaris 1bfabb3
fix a navigation crash when unisizedcontainer used vAlign different f…
Endaris 869658f
update Understanding the Codebase doc with info about the new layout …
Endaris 26cdfec
extract CharacterButton from CharacterSelect into its own UIElement
Endaris a0b814a
update doc how localization is implemented in the Label UIElement
Endaris 5f70845
add a new command line flag to simulate mobile OS instead of doing it…
Endaris 344c09c
no layouting
Endaris ef9a7af
start working on an integrated cursor system and fix some luaLS intel…
Endaris 8b27fc6
widely use import with the luaLS plugin so it properly resolves relat…
Endaris b9bbe0a
change receiveInputs to be cursor driven to achieve a UI system in wh…
Endaris 8fadb86
fix getScreenPos() for children living in ScrollContainers not yieldi…
Endaris 24015c5
fix touch detection in ScrollContainers and mostly unbrick DesignHelper
Endaris d8a47fa
some cleanup
Endaris 4d4b0ff
more cleanup
Endaris a345524
port client parts of consts.lua to its own file
Endaris 80c2730
wrap characterSelect buttons in scrollcontainer and fix a bug that ca…
Endaris e60743e
fix characterbutton offsets
Endaris cb56357
fix CharacterButton display
Endaris a0220d6
fix cursor navigation on UniSizedContainer
Endaris e5b1e11
only show super select stage while a character is hovered (cause it c…
Endaris af1fbce
add PanelSetButton
Endaris ee12a09
fix some things regarding resizing with overflowing height
Endaris e8bb9df
4-slice the cursor image and draw the cursor properly
Endaris 2b800af
fix vertical resizing for preferred vs min height
Endaris ad10ad2
make onChildrenChanged local
Endaris b514bd1
change UIElement:drawSelf and all its override to assume 0, 0 offset …
Endaris dbff55d
readjust MenuItem
Endaris 0eef8fb
update doc
Endaris 389e916
divide Button clicks into action and onAction
Endaris 9d58ae1
fix some stuff about images and stagebuttons
Endaris File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+831 Bytes
(120%)
client/assets/themes/Panel Attack Modern/default/stage/thumbnail.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should probably be a root element that all scenes are parented from, that way we can draw overlays on it etc and it is always the root spot to update scale / height / width on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
This is still WIP and I did this quick and dirty to get a layout resize for window resizes so I could test the layout at all. I intend to come back to this.