Skip to content

Batch send fix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
panicfilip wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Batch send fix #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff2d42e
batch send failure #31
Dec 24, 2017
7e47486
fix coding style
Dec 24, 2017
4a65cad
fix coding style
Dec 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/ApnChannel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ public function send($notifiable, Notification $notification)
'error' => $response->getCode(),
])
);
//connection is useless so create a new connection
$this->closeConnection();
$this->openConnection();
}
} catch (Exception $e) {
throw SendingFailed::create($e);
Expand Down
8 changes: 4 additions & 4 deletions tests/ApnChannelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

namespace NotificationChannels\Gcm\Test;

use Mockery;
use PHPUnit_Framework_TestCase;
use Illuminate\Events\Dispatcher;
use Illuminate\Notifications\Notifiable;
use NotificationChannels\Apn\ApnChannel;
use Illuminate\Notifications\Notification;
use NotificationChannels\Apn\ApnFeedback;
use NotificationChannels\Apn\ApnMessage;
use PHPUnit_Framework_TestCase;
use Mockery;
use NotificationChannels\Apn\ApnFeedback;
use Illuminate\Notifications\Notification;
use ZendService\Apple\Apns\Client\Message as Client;
use ZendService\Apple\Apns\Client\Feedback as FeedbackClient;
use ZendService\Apple\Apns\Response\Message as MessageResponse;
Expand Down