type_for_unit was comparing with incorrect case for Bco16 types.#11
Open
TimAidley wants to merge 1 commit intopatricksurry:masterfrom
Open
type_for_unit was comparing with incorrect case for Bco16 types.#11TimAidley wants to merge 1 commit intopatricksurry:masterfrom
TimAidley wants to merge 1 commit intopatricksurry:masterfrom
Conversation
Fixes case error when determining type for Bco16 data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that Bco16 data types were being unrecognized, and stepping through I found that u['name_std'] was being set to 'Bco16', but compared to 'BCO16', which I think is incorrect. The type is correctly set with this change.